Fix #5636: properly type param accessors in constructors #6746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the condition as suggested in the comment, the referenced test failures do not seem to happen anymore.
smarter
commented
Jun 25, 2019
| else { | ||
| val effectiveOwner = | ||
| if (curOwner.isTerm && defDenot.symbol.isType) | ||
| if (curOwner.isTerm && defDenot.symbol.maybeOwner.isType) |
There was a problem hiding this comment.
The following alternative check passes all tests too:
Suggested change
| if (curOwner.isTerm && defDenot.symbol.maybeOwner.isType) | |
| if (curOwner.isConstructor) |
This looks more obviously correct to me, wdyt @odersky ?
There was a problem hiding this comment.
No, I think curOwner could also be localDummy. maybeOwner.isType looks correct.
odersky
approved these changes
Jun 26, 2019
| else { | ||
| val effectiveOwner = | ||
| if (curOwner.isTerm && defDenot.symbol.isType) | ||
| if (curOwner.isTerm && defDenot.symbol.maybeOwner.isType) |
There was a problem hiding this comment.
No, I think curOwner could also be localDummy. maybeOwner.isType looks correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the condition as suggested in the comment, the referenced test
failures do not seem to happen anymore.